Skip to content

Adapt to the new pycolmap interface - #446

Closed
B1ueber2y wants to merge 9 commits into
cvg:masterfrom
B1ueber2y:features/fix_pycolmap
Closed

Adapt to the new pycolmap interface#446
B1ueber2y wants to merge 9 commits into
cvg:masterfrom
B1ueber2y:features/fix_pycolmap

Conversation

@B1ueber2y

@B1ueber2y B1ueber2y commented Dec 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #440
Fixes #438

@B1ueber2y
B1ueber2y marked this pull request as draft December 12, 2024 16:05
@B1ueber2y
B1ueber2y marked this pull request as ready for review December 12, 2024 16:44
@B1ueber2y B1ueber2y mentioned this pull request Dec 12, 2024
Merged
@B1ueber2y
B1ueber2y marked this pull request as draft December 16, 2024 08:13
@B1ueber2y
B1ueber2y marked this pull request as ready for review December 16, 2024 08:33
@plusk01

plusk01 commented Dec 25, 2024 •
edited
Loading

Copy link
Copy Markdown

visualization.py

selected = random.Random(seed).sample(image_ids, min(n, len(image_ids)))

complains with TypeError: Population must be a sequence. For dicts or sets, use sorted(d).

due to colmap/colmap@d8b50eb#diff-41d77a1f9328d7e0ee226222fcfa320cf1c503f73f6e43c764a8be80a1c66c79R302

can you add sorted(image_ids) to this PR?

@B1ueber2y

B1ueber2y commented Dec 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

visualization.py

selected = random.Random(seed).sample(image_ids, min(n, len(image_ids)))

complains with TypeError: Population must be a sequence. For dicts or sets, use sorted(d).

due to colmap/colmap@d8b50eb#diff-41d77a1f9328d7e0ee226222fcfa320cf1c503f73f6e43c764a8be80a1c66c79R302

can you add sorted(image_ids) to this PR?

Thanks. This is fixed: 13cfc88.

@B1ueber2y
B1ueber2y marked this pull request as draft February 20, 2025 13:29
@B1ueber2y B1ueber2y mentioned this pull request Feb 28, 2025
Merged
@B1ueber2y B1ueber2y mentioned this pull request Jul 4, 2025
Merged
@B1ueber2y B1ueber2y closed this Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Demo broken with latest COLMAP release Exception in triangulation: 'pycolmap._core.Rigid3d' object has no attribute 'essential_matrix'

2 participants

@B1ueber2y @plusk01